Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation of http headers #14231

Merged
merged 1 commit into from
May 23, 2024

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

  1. When using http1 in the jdk17 version, it will be automatically upgraded to http2. The server converts the header to the http2 header, causing the validation to fail, so we need to remove the validation for the http header.
  2. Move StreamingHttpMessageListener to org.apache.dubbo.rpc.protocol.tri.h12.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean
Copy link
Collaborator

oxsean commented May 23, 2024

LGTM.

Copy link

sonarcloud bot commented May 23, 2024

@chickenlj chickenlj merged commit 6f1a41f into apache:3.3 May 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants