Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support disable Curator EnsembleTracker in ServiceDiscovery #14285

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Jun 5, 2024

What is the purpose of the change

fix #14232 again

Support disable Curator EnsembleTracker in ServiceDiscovery

maybe org.apache.dubbo.registry.zookeeper.util.CuratorFrameworkUtils also need change?

Originally posted in #14281 (comment)

Brief changelog

Support disable Curator EnsembleTracker in ServiceDiscovery

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarqubecloud bot commented Jun 5, 2024

@AlbumenJ AlbumenJ merged commit a534350 into apache:3.2 Jun 5, 2024
19 checks passed
@aofall
Copy link
Contributor Author

aofall commented Aug 24, 2024

@AlbumenJ This pull request looks like caused a breaking changes.

#14559 (comment)

Whether it is necessary to use the reflection API to determine whether the method exists to ensure the dubbo 3.2 with curator4 compatibility?

Or revert this pull request.

@AlbumenJ
Copy link
Member

@AlbumenJ This pull request looks like caused a breaking changes.

#14559 (comment)

Whether it is necessary to use the reflection API to determine whether the method exists to ensure the dubbo 3.2 with curator4 compatibility?

Or revert this pull request.

How can we compact it? I will revert it first and then you can submit a new PR to patch it.

@aofall
Copy link
Contributor Author

aofall commented Aug 26, 2024

How can we compact it?

A demo, use Reflect API to check method exists first, if method not exist it will run into catch exception, and this method will not be called, so it will not throw the NoSuchMethodError to compatible with curator4. And support the new feature with curator5.

aofall@9b3ea08

@aofall
Copy link
Contributor Author

aofall commented Aug 26, 2024

A demo, use Reflect API to check method exists first, if method not exist it will run into catch exception, and this method will not be called, so it will not throw the NoSuchMethodError to compatible with curator4. And support the new feature with curator5.

aofall@9b3ea08

@AlbumenJ If use Reflect API is allowed i will submit new PR to patch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants