Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3.2): injvm invoker throws ClassCastException #14346

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

caoyanan666
Copy link
Contributor

@caoyanan666 caoyanan666 commented Jun 19, 2024

What is the purpose of the change

The background is that I have a jvm and started two services. Because the two services have dependent jar packages that conflict, each service has its own class loader. Then because it is in a jvm, I want to use injvm rpc. Currently, Dubbo Core is shared, and SpringInjectExtension is isolated for each service class loader.
Now I encounter a ClassCaseException
image

There is a variable named consumerServiceModel, but its type is ProviderModule
image

I think the current Invoker is actually the consumer Thread. Then the Module in the url is the provider. If the consumer and provider class loaders are different, I understand that the classloader of the current Thread should be used directly instead of the classloader in the url.
So I commit this PR, and the code has been verified locally.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

@AlbumenJ AlbumenJ merged commit 4be8594 into apache:3.2 Jun 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants