Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #1431 #1435

Closed
wants to merge 1 commit into from
Closed

fixed #1431 #1435

wants to merge 1 commit into from

Conversation

kimmking
Copy link
Member

@kimmking kimmking commented Mar 8, 2018

What is the purpose of the change

fixed #1431

Brief changelog

prevent invoking log method when getLogHost exception occurs.

Verifying this change

Unit Tests OK

@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #1435 into master will decrease coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   31.59%   31.56%   -0.04%     
==========================================
  Files         682      682              
  Lines       33035    33048      +13     
  Branches     6592     6595       +3     
==========================================
- Hits        10439    10432       -7     
- Misses      20744    20760      +16     
- Partials     1852     1856       +4
Impacted Files Coverage Δ
.../java/com/alibaba/dubbo/common/utils/NetUtils.java 14.28% <20%> (-1.39%) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) ⬇️
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 54.54% <0%> (-2.03%) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 55.22% <0%> (-1.5%) ⬇️
.../alibaba/dubbo/config/AbstractInterfaceConfig.java 38% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca021c...170f7b1. Read the comment docs.

@leiwei2094
Copy link
Contributor

Hi, kimming, there are some conflict in your PR #1435. Could you please update the PR, thanks.

@beiwei30
Copy link
Member

Hi @kimmking, I use one simple way to avoid this issue, pls. check 70ec90d

@beiwei30 beiwei30 closed this Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants