Condition route v3.1 #14356
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.dubbo.rpc.cluster.router.condition.config.model; | ||
|
|
||
| import org.apache.dubbo.rpc.cluster.router.condition.matcher.ConditionMatcher; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static org.apache.dubbo.rpc.cluster.Constants.DefaultRouteConditionSubSetWeight; | ||
|
|
||
| public class ConditionSubSet { | ||
| private Map<String, ConditionMatcher> condition = new HashMap<>(); | ||
| private Integer subSetWeight; | ||
|
|
||
| public ConditionSubSet() {} | ||
|
|
||
| public ConditionSubSet(Map<String, ConditionMatcher> condition, Integer subSetWeight) { | ||
| this.condition = condition; | ||
| this.subSetWeight = subSetWeight; | ||
| if (subSetWeight <= 0) { | ||
| this.subSetWeight = DefaultRouteConditionSubSetWeight; | ||
| } | ||
| } | ||
|
|
||
| public Map<String, ConditionMatcher> getCondition() { | ||
| return condition; | ||
| } | ||
|
|
||
| public void setCondition(Map<String, ConditionMatcher> condition) { | ||
| this.condition = condition; | ||
| } | ||
|
|
||
| public Integer getSubSetWeight() { | ||
| return subSetWeight; | ||
| } | ||
|
|
||
| public void setSubSetWeight(int subSetWeight) { | ||
| this.subSetWeight = subSetWeight; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "ConditionSubSet{" + "cond=" + condition + ", subSetWeight=" + subSetWeight + '}'; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.dubbo.rpc.cluster.router.condition.config.model; | ||
|
|
||
| import org.apache.dubbo.rpc.Invoker; | ||
| import org.apache.dubbo.rpc.cluster.router.state.BitList; | ||
|
|
||
| public class Destination<T> { | ||
| private int weight; | ||
| private BitList<Invoker<T>> invokers; | ||
|
|
||
| Destination(int weight, BitList<Invoker<T>> invokers) { | ||
| this.weight = weight; | ||
| this.invokers = invokers; | ||
| } | ||
|
|
||
| public int getWeight() { | ||
| return weight; | ||
| } | ||
|
|
||
| public void setWeight(int weight) { | ||
| this.weight = weight; | ||
| } | ||
|
|
||
| public BitList<Invoker<T>> getInvokers() { | ||
| return invokers; | ||
| } | ||
|
|
||
| public void setInvokers(BitList<Invoker<T>> invokers) { | ||
| this.invokers = invokers; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should clone
invokershere firstThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if cloning is necessary here; the v3.0 logic just passes the filtering on invokers itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the route method, the value in invokers is not modified directly, and there are three cases:
1.Return invokers directly
2. return BItlist.empty
3. The invokers will be cloned and modified then return
so I don't think it is necessary to clone first here, just keep the same with v3.0