Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test coverage for org.apache.dubbo.rpc.protocol.dubbo.pu #14503

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

StudentGu
Copy link
Contributor

@StudentGu StudentGu commented Aug 7, 2024

What is the purpose of the change

add test case #14502

Brief changelog

add some test case

This work is done by Tongyiling code:

  1. Unit test class generation
  2. Revise the test case with each adjustment question
  3. Remove Chinese comments and generate English comments
    dubbo

Verifying this change

all test is success
image
image
image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@StudentGu
Copy link
Contributor Author

@AlbumenJ Please Take A Look

Copy link

sonarqubecloud bot commented Aug 7, 2024

@CrazyHZM CrazyHZM merged commit a0c9017 into apache:3.2 Aug 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants