Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support disable Curator EnsembleTracker #14597

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Aug 27, 2024

What is the purpose of the change

fix #14559

Curator5 has a new feature about EnsembleTracker, the dubbo-registry-zookeeper module introduces curator5 dependency default, but it still compatible with Curator4 because all the classes and method are also exist in curator4 exclude the ensembleTracker() method so it works fine.

If we want to support the new feature about Curator5 and compatible with Curator4 together, it need to check the method exist to avoid occur the NoSuchMethodError.

Brief changelog

Support disable Curator EnsembleTracker and compatible with curator4

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Support disable Curator EnsembleTracker and compatible with curator4
Copy link

@AlbumenJ AlbumenJ merged commit a9fedd5 into apache:3.2 Aug 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants