Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BraveAutoConfiguration.java A bean with that name has already been defined #14631

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

he-jialin
Copy link
Contributor

@he-jialin he-jialin commented Sep 5, 2024

The bean 'correlationFieldsCorrelationScopeCustomizer', defined in class path resource [org/apache/dubbo/spring/boot/observability/autoconfigure/brave/BraveAutoConfiguration$BraveBaggageConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [org/springframework/boot/actuate/autoconfigure/tracing/BravePropagationConfigurations$PropagationWithBaggage.class] and overriding is disabled.

What is the purpose of the change

According to dubbo3 design specifications, spring.main.allow-bean-definition-overriding=true should not be set as the default, so this problem needs to be fixed.

#14628

Brief changelog

Add the annotation @ConditionalOnMissingBean to determine whether the bean needs to be injected

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

The bean 'correlationFieldsCorrelationScopeCustomizer', defined in class path resource [org/apache/dubbo/spring/boot/observability/autoconfigure/brave/BraveAutoConfiguration$BraveBaggageConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [org/springframework/boot/actuate/autoconfigure/tracing/BravePropagationConfigurations$PropagationWithBaggage.class] and overriding is disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants