Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project dir and remove pom module #14850

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Nov 3, 2024

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

Signed-off-by: “JermaineHua” <crazyhzm@gmail.com>
@@ -972,14 +997,28 @@
</properties>
</profile>
<profile>
<id>demo</id>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this profile, there are some test or development scenarios, do not want to compile and package demos, this will consume a lot of time and storage space

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don‘t know where to use it.

@@ -1,29 +0,0 @@
# Dubbo Demo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this document is still valuable, or maybe put it in the root readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxsean The content of this document is a little behind, later write a separate demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants