Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo]: Fix the bug that isDefault configuration is not useful #12961 #14888

Open
wants to merge 2 commits into
base: 3.3
Choose a base branch
from

Conversation

paradiseidler
Copy link
Contributor

What is the purpose of the change?

Fix #12961
The tag with attribute=false for the isDefault property has been removed.
1
3

In the isIgnoredAttribute method, due to isDefault having attribute=false, the entire method returns a Boolean value of true.

2

In the assignProperties method of the AbstractConfig class, at the breakpoint, the final condition evaluates to false, preventing the default property assignment process from being executed, resulting in the default value remaining unprocessed as null.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.20%. Comparing base (ef6e8bd) to head (69de5fb).
Report is 56 commits behind head on 3.3.

Additional details and impacted files
@@              Coverage Diff              @@
##              3.3    #14888        +/-   ##
=============================================
- Coverage   37.53%     2.20%    -35.34%     
=============================================
  Files        1813     26083     +24270     
  Lines       80737   1389674   +1308937     
  Branches    12005    220210    +208205     
=============================================
+ Hits        30304     30588       +284     
- Misses      46042   1354645   +1308603     
- Partials     4391      4441        +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change also impacts the hashCode equals logic, possibly already existing configurations change from being equal to now not equal.
If it's really necessary, may need to add a new annotation property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default in protocols not work
3 participants