Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #14980 #15129

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from
Open

issue #14980 #15129

wants to merge 1 commit into from

Conversation

Akshaypa91
Copy link

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@Akshaypa91
Copy link
Author

issue #14980

@heliang666s
Copy link
Contributor

Thanks for your contribution~However, You should run mvn spotless:apply to format before commit your code.@Akshaypa91

@AlbumenJ
Copy link
Member

image

Copy link
Author

@Akshaypa91 Akshaypa91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check

@zrlw
Copy link
Contributor

zrlw commented Feb 17, 2025

@Akshaypa91

  1. should not write // at the end of statement.
  2. should not write space charaecters at the end of statement.
    you can fixed them manully or by running mvn spotless:apply through:
1. change mvn runner to jdk17 as spotless must be runned under jdk17+.
3.  run mvn spotless:apply to fix you code format problems.
4.  push changed codes again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants