Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test tracked by issue#1682 #1889

Merged
merged 2 commits into from
Jun 6, 2018
Merged

unit test tracked by issue#1682 #1889

merged 2 commits into from
Jun 6, 2018

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jun 5, 2018

What is the purpose of the change

#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules

Brief changelog

dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/LogHelperTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/LogTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/LogUtilTest.java

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

beiwei30 added 2 commits June 5, 2018 18:52
…/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
@codecov-io
Copy link

Codecov Report

Merging #1889 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1889      +/-   ##
============================================
+ Coverage     42.57%   42.71%   +0.14%     
- Complexity     4710     4737      +27     
============================================
  Files           646      646              
  Lines         30657    30657              
  Branches       5378     5378              
============================================
+ Hits          13051    13096      +45     
+ Misses        15594    15511      -83     
- Partials       2012     2050      +38
Impacted Files Coverage Δ Complexity Δ
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-12.5%) 3% <0%> (ø)
...a/dubbo/remoting/transport/netty/NettyChannel.java 57.5% <0%> (-8.75%) 19% <0%> (-2%)
...n/java/com/alibaba/dubbo/common/utils/JVMUtil.java 72.22% <0%> (-7.41%) 13% <0%> (-2%)
...libaba/com/caucho/hessian/util/IdentityIntMap.java 25% <0%> (-5.96%) 5% <0%> (-2%)
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...baba/dubbo/remoting/transport/mina/MinaClient.java 57.81% <0%> (-1.57%) 8% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
.../main/java/com/alibaba/dubbo/common/utils/Log.java 35.13% <0%> (+8.1%) 9% <0%> (+3%) ⬆️
...ba/dubbo/remoting/transport/netty/NettyClient.java 82.75% <0%> (+8.62%) 13% <0%> (+1%) ⬆️
...java/com/alibaba/dubbo/common/utils/LogHelper.java 40% <0%> (+40%) 15% <0%> (+15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5856d4f...1efd638. Read the comment docs.

@beiwei30 beiwei30 merged commit 86984e6 into apache:master Jun 6, 2018
@beiwei30 beiwei30 deleted the common-util-unit-test branch June 6, 2018 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants