Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for UrlUtils #1906

Merged
merged 2 commits into from
Jun 11, 2018
Merged

unit test for UrlUtils #1906

merged 2 commits into from
Jun 11, 2018

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jun 8, 2018

What is the purpose of the change

#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules

Brief changelog

dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/UrlUtilsTest.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

beiwei30 added 2 commits June 8, 2018 15:42
…/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
…/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
@codecov-io
Copy link

Codecov Report

Merging #1906 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1906      +/-   ##
============================================
+ Coverage      49.4%   49.54%   +0.14%     
- Complexity     4491     4505      +14     
============================================
  Files           558      558              
  Lines         24346    24346              
  Branches       4315     4315              
============================================
+ Hits          12027    12062      +35     
+ Misses        10474    10424      -50     
- Partials       1845     1860      +15
Impacted Files Coverage Δ Complexity Δ
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-11.12%) 5% <0%> (-2%)
...on/src/main/java/com/alibaba/dubbo/common/URL.java 26.64% <0%> (+0.29%) 80% <0%> (+2%) ⬆️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+3%) ⬆️
.../java/com/alibaba/dubbo/common/utils/UrlUtils.java 75.98% <0%> (+8.6%) 74% <0%> (+10%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 84.61% <0%> (+11.53%) 8% <0%> (ø) ⬇️
...va/com/alibaba/dubbo/config/DubboShutdownHook.java 73.91% <0%> (+30.43%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88aa3b5...3846f47. Read the comment docs.

@beiwei30 beiwei30 merged commit 5d21088 into apache:master Jun 11, 2018
@beiwei30 beiwei30 deleted the common-utils-unit-test branch June 11, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants