Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix protocol version compatibility on master #2118

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

diecui1202
Copy link

What is the purpose of the change

fix protocol version compatibility

Brief changelog

dubbo-common/.../Version.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@diecui1202 diecui1202 changed the title fix protocol version compatibility fix protocol version compatibility on master Jul 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #2118 into master will increase coverage by 0.02%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2118      +/-   ##
============================================
+ Coverage      54.1%   54.13%   +0.02%     
- Complexity     5078     5080       +2     
============================================
  Files           559      559              
  Lines         24908    24922      +14     
  Branches       4438     4442       +4     
============================================
+ Hits          13477    13492      +15     
+ Misses         9395     9389       -6     
- Partials       2036     2041       +5
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/apache/dubbo/common/Version.java 48.23% <52.94%> (-1.07%) 15 <2> (+2)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 47.68% <0%> (+0.71%) 38% <0%> (ø) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.16% <0%> (+0.83%) 31% <0%> (+1%) ⬆️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 78.67% <0%> (+1.47%) 29% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty4/NettyServer.java 75.4% <0%> (+3.27%) 10% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (+3.75%) 22% <0%> (+1%) ⬆️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (+4.16%) 3% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec30bf...f3e817d. Read the comment docs.

@diecui1202
Copy link
Author

#2104

@chickenlj chickenlj merged commit 0b6e6f3 into apache:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants