Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation activate compatible #2152

Merged
merged 4 commits into from
Aug 2, 2018

Conversation

diecui1202
Copy link

What is the purpose of the change

support @activate for compatible

Brief changelog

Verifying this change

unit tests pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #2152 into master will decrease coverage by <.01%.
The diff coverage is 85.1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2152      +/-   ##
============================================
- Coverage     54.23%   54.23%   -0.01%     
- Complexity     5097     5102       +5     
============================================
  Files           559      559              
  Lines         24945    24972      +27     
  Branches       4445     4449       +4     
============================================
+ Hits          13530    13544      +14     
- Misses         9377     9389      +12     
- Partials       2038     2039       +1
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/com/alibaba/dubbo/rpc/Invoker.java 36.36% <100%> (ø) 0 <0> (ø) ⬇️
...o/common/extension/support/ActivateComparator.java 70.9% <84.37%> (+29.24%) 19 <0> (+7) ⬆️
...apache/dubbo/common/extension/ExtensionLoader.java 72.94% <85.71%> (+0.23%) 118 <0> (+2) ⬆️
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-10.17%) 12% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 57.5% <0%> (-8.75%) 21% <0%> (-2%)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java 50% <0%> (+8.33%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90d95c...b071341. Read the comment docs.

@diecui1202
Copy link
Author

#2144

import org.apache.dubbo.common.extension.activate.impl.ActivateExt1Impl1;
import org.apache.dubbo.common.extension.activate.impl.GroupActivateExtImpl;
import org.apache.dubbo.common.extension.activate.impl.OrderActivateExtImpl1;
import org.apache.dubbo.common.extension.activate.impl.OrderActivateExtImpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.* is not a good usage

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the IDEA does this job automatically

@diecui1202
Copy link
Author

#2140

@@ -148,12 +148,12 @@ Please follow the [template](https://github.com/apache/incubator-dubbo/issues/ne

Please report security vulnerability to security@dubbo.incubator.apache.org (private mailing list).

## Ecosystem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest one target with one PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it. I will follow it from next PR. Thanks.

@diecui1202 diecui1202 merged commit 7cb044c into apache:master Aug 2, 2018
carryxyh pushed a commit to carryxyh/incubator-dubbo that referenced this pull request Aug 2, 2018
* support @activate for compatible

* add testcase for @activate compatible

* add LICENSE for test class

* import format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants