-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation activate compatible #2152
Annotation activate compatible #2152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2152 +/- ##
============================================
- Coverage 54.23% 54.23% -0.01%
- Complexity 5097 5102 +5
============================================
Files 559 559
Lines 24945 24972 +27
Branches 4445 4449 +4
============================================
+ Hits 13530 13544 +14
- Misses 9377 9389 +12
- Partials 2038 2039 +1
Continue to review full report at Codecov.
|
import org.apache.dubbo.common.extension.activate.impl.ActivateExt1Impl1; | ||
import org.apache.dubbo.common.extension.activate.impl.GroupActivateExtImpl; | ||
import org.apache.dubbo.common.extension.activate.impl.OrderActivateExtImpl1; | ||
import org.apache.dubbo.common.extension.activate.impl.OrderActivateExtImpl2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.* is not a good usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the IDEA does this job automatically
@@ -148,12 +148,12 @@ Please follow the [template](https://github.com/apache/incubator-dubbo/issues/ne | |||
|
|||
Please report security vulnerability to security@dubbo.incubator.apache.org (private mailing list). | |||
|
|||
## Ecosystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest one target with one PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it. I will follow it from next PR. Thanks.
What is the purpose of the change
support @activate for compatible
Brief changelog
Verifying this change
unit tests pass
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.