Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subscription when enable monitor #2167

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

jasonjoo2010
Copy link
Contributor

What is the purpose of the change

same fix on monitor in 2.7.x

because there is bug which willl block shutdown progress in 2.5.x and it was fixed in 2.6.3.

related: #2110

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2167 into master will increase coverage by 0.36%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2167      +/-   ##
============================================
+ Coverage     54.26%   54.63%   +0.36%     
- Complexity     5103     5129      +26     
============================================
  Files           559      559              
  Lines         24947    25187     +240     
  Branches       4447     4568     +121     
============================================
+ Hits          13538    13760     +222     
- Misses         9373     9385      +12     
- Partials       2036     2042       +6
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/config/AbstractInterfaceConfig.java 80.78% <57.14%> (-0.75%) 81 <0> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.57% <0%> (-7.15%) 10% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...e/src/main/java/com/alibaba/dubbo/rpc/Invoker.java 33.33% <0%> (-3.04%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 57.89% <0%> (-1.06%) 18% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 58.33% <0%> (-0.84%) 30% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+2%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62e15d...0ffbde9. Read the comment docs.

@zonghaishang zonghaishang merged commit 584de00 into apache:master Aug 2, 2018
carryxyh pushed a commit to carryxyh/incubator-dubbo that referenced this pull request Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants