Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-#2162]Correct the reference retries default value 0 to 2 #2183

Merged
merged 2 commits into from
Aug 15, 2018
Merged

[Dubbo-#2162]Correct the reference retries default value 0 to 2 #2183

merged 2 commits into from
Aug 15, 2018

Conversation

tswstarplanet
Copy link
Contributor

No description provided.

@ralf0131
Copy link
Contributor

ralf0131 commented Aug 4, 2018

Hi, please check the CI failure first.

@codecov-io
Copy link

Codecov Report

Merging #2183 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2183      +/-   ##
============================================
- Coverage      54.3%   54.27%   -0.03%     
+ Complexity     5110     5109       -1     
============================================
  Files           559      559              
  Lines         24996    24996              
  Branches       4456     4456              
============================================
- Hits          13574    13567       -7     
- Misses         9387     9394       +7     
  Partials       2035     2035
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 7% <0%> (-1%)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 45.83% <0%> (-4.17%) 3% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 50.7% <0%> (-0.71%) 43% <0%> (ø)
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 54.43% <0%> (+2.53%) 12% <0%> (+1%) ⬆️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 88.88% <0%> (+5.55%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e1e62...0686c96. Read the comment docs.

@diecui1202
Copy link

@tswstarplanet Does this PR need to merge to 2.6.x ?

@diecui1202
Copy link

#2162

@diecui1202 diecui1202 added the status/waiting-for-feedback Need reporters to triage label Aug 10, 2018
@tswstarplanet
Copy link
Contributor Author

@diecui1202 Sorry, should I determine what branch this commit to be merged ?

@diecui1202
Copy link

@tswstarplanet This is a bug, so I think it needs to be merged to master and 2.6.x.

You may need to file 2 PRs, one to master, and one to 2.6.x.

@diecui1202
Copy link

I think we can merge this PR first. And then start a new PR for 2.6.x

@diecui1202
Copy link

The PR for 2.6.x is #2303

@diecui1202 diecui1202 merged commit f2188d3 into apache:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants