Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance shutdown hook in spring #3008

Merged
merged 1 commit into from
Dec 18, 2018
Merged

enhance shutdown hook in spring #3008

merged 1 commit into from
Dec 18, 2018

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

enhance shutdown hook in spring, make sure shutdown hook always work in spring, no matter spring framework registers shutdown hook or not.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@zonghaishang zonghaishang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@codecov-io
Copy link

Codecov Report

Merging #3008 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
- Coverage   64.29%   64.28%   -0.02%     
==========================================
  Files         584      584              
  Lines       26055    26056       +1     
  Branches     4561     4562       +1     
==========================================
- Hits        16753    16749       -4     
+ Misses       7124     7123       -1     
- Partials     2178     2184       +6
Impacted Files Coverage Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 81.25% <ø> (+5.49%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 85.36% <100%> (+0.75%) ⬆️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 85.71% <0%> (-3.58%) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 70.17% <0%> (-1.76%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4acdf7...81d73be. Read the comment docs.

@zonghaishang zonghaishang merged commit df219f3 into apache:master Dec 18, 2018
@beiwei30 beiwei30 deleted the shutdown-hook branch December 19, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants