Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review code of TypeDefinitionBuilder #3064

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Review code of TypeDefinitionBuilder #3064

merged 3 commits into from
Jan 25, 2019

Commits on Dec 28, 2018

  1. Review code of TypeDefinitionBuilder 

    1. use init method to init builds' list
    @carryxyh
    carryxyh committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    c26b361 View commit details
    Browse the repository at this point in the history

  2. use single list for all builders. 

    Seems like the builder is thread-safe, we can keep them static and final.
    @carryxyh
    carryxyh committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    cfd5cd5 View commit details
    Browse the repository at this point in the history

  3. clean code.

    @carryxyh
    carryxyh committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    e9cd365 View commit details
    Browse the repository at this point in the history