Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-1917] fix use condition properly fix #1917 #3087

Closed
wants to merge 1 commit into from

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Dec 28, 2018

What is the purpose of the change

fix #1917
I suspect that if there is an exception in the subscription to Redis, when the disconnection is successful, we can think that the Redis connection is broken, we need to re-initiate the subscription, and we need to get the latest data from Redis again. But in JedisPool, no connection monitoring mechanism is provided.
The first attribute is to achieve the effect of connection monitoring.
If my idea is correct, please review this pr

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition is not properly used ?
1 participant