Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the configurtion to work default with multicast address #3092

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

khanimteyaz
Copy link
Contributor

What is the purpose of the change

Making changes in dubbo-demo-consumer.xml to use multicast as provider is configured to multicast. So that dubbo demo user can use the sample without any external configuration.

Brief changelog

Making changes in dubbo-demo-consumer.xml to use multicast as provider is configured to multicast. So that dubbo demo user can use the sample without any external configuration.

Verifying this change

Running locally dubbo-demo provider and consumer and seeing the request-response messages.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3092 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3092      +/-   ##
============================================
- Coverage      63.5%   63.46%   -0.05%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28251    28251              
  Branches       4816     4816              
============================================
- Hits          17942    17930      -12     
- Misses         8040     8046       +6     
- Partials       2269     2275       +6
Impacted Files Coverage Δ Complexity Δ
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.15% <0%> (-2.02%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) 0% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 72.5% <0%> (-1.67%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.95% <0%> (+0.37%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.95% <0%> (+0.75%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09cbf8f...90fe7ea. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request!

@ralf0131 ralf0131 merged commit 5c54c68 into apache:master Dec 29, 2018
@khanimteyaz khanimteyaz mentioned this pull request Dec 29, 2018
2 tasks
khanimteyaz added a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants