Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3342] Fix NullPointerException when Hessian instantiate URL with JavaDeserializer #3342 #3350

Merged
merged 1 commit into from
Jan 25, 2019
Merged

[Dubbo-3342] Fix NullPointerException when Hessian instantiate URL with JavaDeserializer #3342 #3350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dubbo-compatible/src/main/java/com/alibaba/dubbo/common/URL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
@Deprecated
public class URL extends org.apache.dubbo.common.URL {

protected URL() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like public is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carryxyh I don't think so. Because a good URL must have basic information, such as protocol, host, port.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmm...
Maybe u are right. Seems like a protected constructor can fix this problem, too.

super();
}

public URL(org.apache.dubbo.common.URL url) {
super(url.getProtocol(), url.getUsername(), url.getPassword(), url.getHost(), url.getPort(), url.getPath(), url.getParameters());
}
Expand Down