Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-900] Fix 通过 override 修改 hessian协议的提供者的配置 不生效 #900 #3363

Merged
merged 5 commits into from
Jan 28, 2019
Merged

[Dubbo-900] Fix 通过 override 修改 hessian协议的提供者的配置 不生效 #900 #3363

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
614396e
reExport fail fix#900
CrazyHZM Jan 27, 2019
7cbfaf7
modify
CrazyHZM Jan 27, 2019
e22502a
use Objects.equals
CrazyHZM Jan 27, 2019
3ba230f
compare URL for all proxy protocol
CrazyHZM Jan 28, 2019
8a03237
Merge branch 'master' into fixReExportFail
CrazyHZM Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractProxyProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,14 @@ public <T> Exporter<T> export(final Invoker<T> invoker) throws RpcException {
final String uri = serviceKey(invoker.getUrl());
Exporter<T> exporter = (Exporter<T>) exporterMap.get(uri);
if (exporter != null) {
return exporter;
// When modifying the configuration through override, you need to re-expose the newly modified service.
if ("hessian".equals(invoker.getUrl().getProtocol())) {
beiwei30 marked this conversation as resolved.
Show resolved Hide resolved
if (exporter.getInvoker().getUrl().equals(invoker.getUrl())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could getUrl return null here? If so, Objects.equals might be better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I will modify it.

return exporter;
}
} else {
return exporter;
}
}
final Runnable runnable = doExport(proxyFactory.getProxy(invoker, true), invoker.getInterface(), invoker.getUrl());
exporter = new AbstractExporter<T>(invoker) {
Expand Down