Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3991]: port #3568 into main trunk #3993

Merged
merged 1 commit into from
May 10, 2019
Merged

[DUBBO-3991]: port #3568 into main trunk #3993

merged 1 commit into from
May 10, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented May 8, 2019

What is the purpose of the change

the change proposed in #3568 is reasonable, port it into main trunk

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3993 into master will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3993      +/-   ##
============================================
- Coverage     63.76%   63.68%   -0.08%     
  Complexity      565      565              
============================================
  Files           744      748       +4     
  Lines         32209    32326     +117     
  Branches       5127     5139      +12     
============================================
+ Hits          20538    20587      +49     
- Misses         9318     9381      +63     
- Partials       2353     2358       +5
Impacted Files Coverage Δ Complexity Δ
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 58.41% <33.33%> (-1.79%) 0 <0> (ø)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 60.46% <0%> (-7.96%) 0% <0%> (ø)
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 75% <0%> (-3.27%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.14% <0%> (-1.37%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.48% <0%> (-0.37%) 0% <0%> (ø)
...protobuf/support/GenericProtobufSerialization.java 0% <0%> (ø) 0% <0%> (?)
.../protobuf/support/GenericProtobufObjectOutput.java 33.33% <0%> (ø) 0% <0%> (?)
...mmon/serialize/protobuf/support/ProtobufUtils.java 56.25% <0%> (ø) 0% <0%> (?)
...e/protobuf/support/GenericProtobufObjectInput.java 34.78% <0%> (ø) 0% <0%> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bed88...e9eb9ef. Read the comment docs.

@beiwei30 beiwei30 requested a review from chickenlj May 9, 2019 06:11
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit d5c5176 into apache:master May 10, 2019
@caojiele caojiele mentioned this pull request May 10, 2019
6 tasks
@chickenlj chickenlj added this to the 2.7.2 milestone May 28, 2019
@cvictory cvictory mentioned this pull request May 28, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants