-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java doc for remote netty4 #4180
Conversation
i have merged the latest code into your branch but still check fail. |
And the problem happen second time at the same UT position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls format your doc.
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
...bo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## master #4180 +/- ##
============================================
+ Coverage 62.87% 62.88% +<.01%
- Complexity 504 506 +2
============================================
Files 769 769
Lines 33058 33058
Branches 5217 5217
============================================
+ Hits 20786 20789 +3
- Misses 9874 9875 +1
+ Partials 2398 2394 -4
Continue to review full report at Codecov.
|
What is the purpose of the change
add some comments for dubbo-remoting-netty4
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.