Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize code style #4188

Merged
merged 12 commits into from
May 31, 2019
Merged

optimize code style #4188

merged 12 commits into from
May 31, 2019

Conversation

slievrly
Copy link
Member

What is the purpose of the change

optimize code style :

  1. Constant naming rules require letters and underscore combinations
  2. All override methods need to add @OverRide

Brief changelog

optimize code style

Verifying this change

ci

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

slievrly added 5 commits May 3, 2019 14:03
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
#	dubbo-remoting/dubbo-remoting-etcd3/src/main/java/org/apache/dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java
#	dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
slievrly added 3 commits May 29, 2019 11:17
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
@slievrly
Copy link
Member Author

@ralf0131 why use CRLF line separators?

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #4188 into master will decrease coverage by 0.02%.
The diff coverage is 94.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4188      +/-   ##
============================================
- Coverage     62.92%   62.89%   -0.03%     
+ Complexity      507      505       -2     
============================================
  Files           769      769              
  Lines         33058    33058              
  Branches       5217     5217              
============================================
- Hits          20802    20793       -9     
- Misses         9860     9867       +7     
- Partials       2396     2398       +2
Impacted Files Coverage Δ Complexity Δ
...ibaba/dubbo/registry/support/AbstractRegistry.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ibaba/dubbo/registry/support/FailbackRegistry.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ml/rpc/protocol/xmlrpc/XmlRpcProxyFactoryBean.java 66.66% <ø> (ø) 5 <0> (ø) ⬇️
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 66.66% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 48.31% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/org/apache/dubbo/rpc/AppResponse.java 72.34% <ø> (ø) 0 <0> (ø) ⬇️
...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java 80% <100%> (ø) 2 <0> (ø) ⬇️
...java/org/apache/dubbo/common/utils/ClassUtils.java 71.13% <100%> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.2% <100%> (ø) 0 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b97a0b...a6d13c5. Read the comment docs.

@slievrly
Copy link
Member Author

@ralf0131 @kexianjun already revert.

Signed-off-by: jimin.jm <slievrly@163.com>
@sofkyle sofkyle mentioned this pull request May 31, 2019
6 tasks
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 177f71b into apache:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants