-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize code style #4188
optimize code style #4188
Conversation
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
# Conflicts: # dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java # dubbo-remoting/dubbo-remoting-etcd3/src/main/java/org/apache/dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java # dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
Outdated
Show resolved
Hide resolved
...dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
@ralf0131 why use CRLF line separators? |
Codecov Report
@@ Coverage Diff @@
## master #4188 +/- ##
============================================
- Coverage 62.92% 62.89% -0.03%
+ Complexity 507 505 -2
============================================
Files 769 769
Lines 33058 33058
Branches 5217 5217
============================================
- Hits 20802 20793 -9
- Misses 9860 9867 +7
- Partials 2396 2398 +2
Continue to review full report at Codecov.
|
Signed-off-by: jimin.jm <slievrly@163.com>
@ralf0131 @kexianjun already revert. |
Signed-off-by: jimin.jm <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
optimize code style :
Brief changelog
optimize code style
Verifying this change
ci
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.