Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] add test for common-config #4208

Merged
merged 4 commits into from
Jun 1, 2019
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented May 30, 2019

Signed-off-by: jimin.jm slievrly@163.com

What is the purpose of the change

[Test] add test for EnvironmentConfiguration、InmemoryConfiguration、SystemConfiguration

Brief changelog

[Test] add test for common-config

Verifying this change

CI

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: jimin.jm <slievrly@163.com>
Copy link

@Moriadry-zz Moriadry-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some little requests, others LGTM

Signed-off-by: jimin.jm <slievrly@163.com>
@slievrly
Copy link
Member Author

@moriadry all fixed.

slievrly added 2 commits May 31, 2019 14:15
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
@codecov-io
Copy link

Codecov Report

Merging #4208 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4208      +/-   ##
===========================================
+ Coverage     62.93%     63%   +0.06%     
+ Complexity      507     505       -2     
===========================================
  Files           769     769              
  Lines         33058   33058              
  Branches       5217    5217              
===========================================
+ Hits          20806   20827      +21     
+ Misses         9858    9826      -32     
- Partials       2394    2405      +11
Impacted Files Coverage Δ Complexity Δ
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <0%> (-1.41%) 20% <0%> (-2%)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 80.14% <0%> (-0.74%) 0% <0%> (ø)
...main/java/org/apache/dubbo/remoting/Constants.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 78.04% <0%> (ø) 0% <0%> (ø) ⬇️
...ibaba/dubbo/registry/support/AbstractRegistry.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...java/org/apache/dubbo/remoting/utils/UrlUtils.java 57.14% <0%> (ø) 0% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 68.42% <0%> (ø) 0% <0%> (ø) ⬇️
...bo/remoting/transport/netty4/NettyTransporter.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...rc/main/java/org/apache/dubbo/rpc/AppResponse.java 72.34% <0%> (ø) 0% <0%> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b97a0b...78cbe91. Read the comment docs.

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants