-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] add test for common-config #4208
Conversation
Signed-off-by: jimin.jm <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some little requests, others LGTM
dubbo-common/src/test/java/org/apache/dubbo/common/config/EnvironmentConfigurationTest.java
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/config/EnvironmentConfigurationTest.java
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/config/InmemoryConfigurationTest.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/config/SystemConfigurationTest.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/test/java/org/apache/dubbo/common/config/SystemConfigurationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jimin.jm <slievrly@163.com>
@moriadry all fixed. |
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## master #4208 +/- ##
===========================================
+ Coverage 62.93% 63% +0.06%
+ Complexity 507 505 -2
===========================================
Files 769 769
Lines 33058 33058
Branches 5217 5217
===========================================
+ Hits 20806 20827 +21
+ Misses 9858 9826 -32
- Partials 2394 2405 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jimin.jm slievrly@163.com
What is the purpose of the change
[Test] add test for EnvironmentConfiguration、InmemoryConfiguration、SystemConfiguration
Brief changelog
[Test] add test for common-config
Verifying this change
CI
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.