-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-4183] Fix unstable tests in ConditionRouterTest #4226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4226 +/- ##
=========================================
Coverage ? 62.89%
Complexity ? 505
=========================================
Files ? 769
Lines ? 33058
Branches ? 5217
=========================================
Hits ? 20791
Misses ? 9869
Partials ? 2398 Continue to review full report at Codecov.
|
testStoreProvider still need someone to have a look. that issue will not close by this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check CRLF or LF line separators in ConditionRouterTest.java.
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If the ip of the ci machine is 10.20.3.*, it will affect the conditional judgment of host = xxxx => host = 10.20.3.* & host != 10.20.3.3
. There are 2 options here: 1. Set the service provider to fixed ip 2. Remove the * judgment of this case
...a-report-etcd/src/test/java/org/apache/dubbo/metadata/store/etcd/EtcdMetadataReportTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Make unit test stable
Brief changelog
Remove network dependency in unit test (ConditionRouterTest) close #4183
Ignore unstable test (EtcdMetadataReportTest) refer #4185
Verifying this change
CI Pass
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.