Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4183] Fix unstable tests in ConditionRouterTest #4226

Merged
merged 3 commits into from
Jun 6, 2019
Merged

[Dubbo-4183] Fix unstable tests in ConditionRouterTest #4226

merged 3 commits into from
Jun 6, 2019

Conversation

htynkn
Copy link
Member

@htynkn htynkn commented May 31, 2019

What is the purpose of the change

Make unit test stable

Brief changelog

Remove network dependency in unit test (ConditionRouterTest) close #4183
Ignore unstable test (EtcdMetadataReportTest) refer #4185

Verifying this change

CI Pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7f7a289). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4226   +/-   ##
=========================================
  Coverage          ?   62.89%           
  Complexity        ?      505           
=========================================
  Files             ?      769           
  Lines             ?    33058           
  Branches          ?     5217           
=========================================
  Hits              ?    20791           
  Misses            ?     9869           
  Partials          ?     2398

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7a289...a405a85. Read the comment docs.

@htynkn htynkn requested a review from lovepoem May 31, 2019 11:57
@htynkn
Copy link
Member Author

htynkn commented May 31, 2019

testStoreProvider still need someone to have a look. that issue will not close by this PR

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check CRLF or LF line separators in ConditionRouterTest.java.

@htynkn
Copy link
Member Author

htynkn commented May 31, 2019

check CRLF or LF line separators in ConditionRouterTest.java.

Fixed

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If the ip of the ci machine is 10.20.3.*, it will affect the conditional judgment of host = xxxx => host = 10.20.3.* & host != 10.20.3.3. There are 2 options here: 1. Set the service provider to fixed ip 2. Remove the * judgment of this case

@lovepoem lovepoem self-requested a review June 6, 2019 14:51
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable UT (ConditionRouterTest.testRoute_matchFilter)
4 participants