Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. 将URL中的默认值使用三目运算符表示。 #4301

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

andyqian
Copy link
Contributor

What is the purpose of the change

将URL类中的默认值,修改为用三目运算符使用。减少冗余代码!

Brief changelog

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4301 into master will increase coverage by 0.01%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4301      +/-   ##
============================================
+ Coverage     62.94%   62.95%   +0.01%     
+ Complexity      506      504       -2     
============================================
  Files           769      769              
  Lines         33041    32995      -46     
  Branches       5215     5215              
============================================
- Hits          20798    20773      -25     
+ Misses         9850     9821      -29     
- Partials       2393     2401       +8
Impacted Files Coverage Δ Complexity Δ
...mon/src/main/java/org/apache/dubbo/common/URL.java 49.4% <30.43%> (-0.6%) 0 <0> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.54%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <0%> (-1.41%) 20% <0%> (-2%)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 59.6% <0%> (-0.67%) 27% <0%> (ø)
...ting/zookeeper/curator/CuratorZookeeperClient.java 64.15% <0%> (+1.25%) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.23% <0%> (+1.35%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0%> (+2.17%) 0% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 71.42% <0%> (+9.52%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acf5b8...f5b7909. Read the comment docs.

Copy link
Contributor

@lixiaojiee lixiaojiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thank you for your contribution.

@lixiaojiee lixiaojiee merged commit 6f3a05c into apache:master Jun 13, 2019
@andyqian andyqian deleted the urlOptimize branch June 14, 2019 09:54
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants