Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify config-center model #4388

Merged
merged 4 commits into from
Jul 4, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

related issues: #4247

docs: apache/dubbo-website#388

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4388 into 2.7.3-release will increase coverage by 0.03%.
The diff coverage is 45%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.3-release    #4388      +/-   ##
===================================================
+ Coverage             63.5%   63.54%   +0.03%     
  Complexity             452      452              
===================================================
  Files                  765      765              
  Lines                32690    32680      -10     
  Branches              5149     5150       +1     
===================================================
+ Hits                 20761    20766       +5     
+ Misses                9542     9523      -19     
- Partials              2387     2391       +4
Impacted Files Coverage Δ Complexity Δ
...figcenter/support/nop/NopDynamicConfiguration.java 71.42% <ø> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...ter/support/apollo/ApolloDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...onfigcenter/consul/ConsulDynamicConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...enter/support/nacos/NacosDynamicConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...gcenter/support/etcd/EtcdDynamicConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 72% <0%> (ø) 0 <0> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <100%> (ø) 0 <0> (ø) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 80.3% <100%> (ø) 0 <0> (ø) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a229d87...e9371fd. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit c4e9495 into apache:2.7.3-release Jul 4, 2019
@chickenlj chickenlj deleted the configcenter-model branch September 3, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants