-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify config-center model #4388
Conversation
...-etcd/src/main/java/org/apache/dubbo/configcenter/support/etcd/EtcdDynamicConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
Show resolved
Hide resolved
...main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 2.7.3-release #4388 +/- ##
===================================================
+ Coverage 63.5% 63.54% +0.03%
Complexity 452 452
===================================================
Files 765 765
Lines 32690 32680 -10
Branches 5149 5150 +1
===================================================
+ Hits 20761 20766 +5
+ Misses 9542 9523 -19
- Partials 2387 2391 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
related issues: #4247
docs: apache/dubbo-website#388
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.