Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nacos dependencies to dubbo-demo #4447

Merged

Conversation

ralf0131
Copy link
Contributor

@ralf0131 ralf0131 commented Jul 2, 2019

What is the purpose of the change

Add nacos dependencies to dubbo-demo

Brief changelog

Add nacos dependencies to dubbo-demo

Verifying this change

Maven test passed

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@ralf0131 ralf0131 requested a review from cvictory July 2, 2019 09:37
@codecov-io
Copy link

Codecov Report

Merging #4447 into 2.7.3-release will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.3-release    #4447      +/-   ##
===================================================
- Coverage             63.5%   63.46%   -0.05%     
+ Complexity             452      451       -1     
===================================================
  Files                  765      765              
  Lines                32690    32696       +6     
  Branches              5149     5151       +2     
===================================================
- Hits                 20761    20751      -10     
- Misses                9542     9556      +14     
- Partials              2387     2389       +2
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-3.07%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...n/java/org/apache/dubbo/common/utils/NetUtils.java 67.05% <0%> (-1.62%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 80.14% <0%> (-0.74%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0%> (+4.34%) 0% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 71.42% <0%> (+9.52%) 0% <0%> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 56.81% <0%> (+11.36%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a229d87...e213204. Read the comment docs.

@cvictory cvictory merged commit 8baf929 into apache:2.7.3-release Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants