Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix convertMethodConfig2AyncInfo spelling error #4563

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

leechor
Copy link
Contributor

@leechor leechor commented Jul 13, 2019

what the problem

rename convertMethodConfig2AyncInfo method name to convertMethodConfig2AsyncInfo

@leechor leechor closed this Jul 13, 2019
@leechor leechor reopened this Jul 13, 2019
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

Codecov Report

Merging #4563 into master will increase coverage by 0.58%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4563      +/-   ##
============================================
+ Coverage     62.38%   62.96%   +0.58%     
+ Complexity      450      449       -1     
============================================
  Files           791      770      -21     
  Lines         34853    33089    -1764     
  Branches       5457     5216     -241     
============================================
- Hits          21742    20835     -907     
+ Misses        10613     9860     -753     
+ Partials       2498     2394     -104
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/config/AbstractConfig.java 79.87% <ø> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.48% <100%> (-0.37%) 0 <0> (ø)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 69.23% <0%> (-12.83%) 0% <0%> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-3.07%) 0% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c304bf3...9440296. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants