Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4585] fix when provider throw RpcException consumer do not invoke mock #4586

Merged
merged 4 commits into from
Jul 18, 2019

Conversation

codeimport
Copy link
Contributor

What is the purpose of the change

fix #4585 when provider throw RpcException consumer do not invoke mock

Brief changelog

modify:dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
add:
dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/wrapper/MockProviderRpcExceptionTest.java

Verifying this change

MockProviderRpcExceptionTest

@codecov-io
Copy link

Codecov Report

Merging #4586 into master will increase coverage by 0.75%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4586      +/-   ##
============================================
+ Coverage     63.26%   64.01%   +0.75%     
  Complexity      450      450              
============================================
  Files           770      768       -2     
  Lines         33016    32873     -143     
  Branches       5219     5181      -38     
============================================
+ Hits          20886    21045     +159     
+ Misses         9728     9419     -309     
- Partials       2402     2409       +7
Impacted Files Coverage Δ Complexity Δ
...pc/cluster/support/wrapper/MockClusterInvoker.java 67.21% <0%> (-6.01%) 0 <0> (ø)
...nnotation/AbstractAnnotationConfigBeanBuilder.java 0% <0%> (-93.34%) 0% <0%> (ø)
...rg/apache/dubbo/config/spring/util/ClassUtils.java 0% <0%> (-75%) 0% <0%> (ø)
...pport/zookeeper/ZookeeperDynamicConfiguration.java 66.66% <0%> (-11.91%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 88% <0%> (-7.46%) 0% <0%> (ø)
...bbo/metadata/definition/TypeDefinitionBuilder.java 92.59% <0%> (-7.41%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 69.23% <0%> (-6.96%) 0% <0%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22670b2...bba0eca. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider throw RpcException but Consumer do not invoke mock
4 participants