Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] fix #4641 . Don't support metadata for generic service. #4660

Merged
merged 19 commits into from
Sep 11, 2019

Conversation

cvictory
Copy link
Contributor

fix #4641

Don't support metadata for generic service.

@cvictory cvictory requested a review from chickenlj July 25, 2019 05:50
@codecov-io
Copy link

Codecov Report

Merging #4660 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4660      +/-   ##
============================================
+ Coverage     63.91%   63.96%   +0.05%     
- Complexity      451      453       +2     
============================================
  Files           769      769              
  Lines         33141    33171      +30     
  Branches       5223     5230       +7     
============================================
+ Hits          21181    21219      +38     
+ Misses         9531     9527       -4     
+ Partials       2429     2425       -4
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 78.04% <ø> (ø) 0 <0> (ø) ⬇️
...bo/metadata/integration/MetadataReportService.java 81.63% <100%> (+3.58%) 0 <0> (ø) ⬇️
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 64.08% <0%> (+1.4%) 22% <0%> (+2%) ⬆️
...e/dubbo/remoting/transport/netty/NettyChannel.java 62.35% <0%> (+4.7%) 21% <0%> (+1%) ⬆️
...n/java/org/apache/dubbo/common/bytecode/Proxy.java 77.7% <0%> (+5.48%) 0% <0%> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 85.36% <0%> (+7.31%) 0% <0%> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 82.05% <0%> (+12.82%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4904d4...667ab02. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ beiwei30
❌ cvictory
You have signed the CLA already but the status is still pending? Let us recheck it.

@cvictory cvictory added this to the 2.7.4 milestone Sep 9, 2019
@chickenlj chickenlj merged commit 7d564e7 into apache:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetadataService logs error msg when using generic implementation.
5 participants