Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4470 fix referenceAnnotation config not work when a dubbo service wa… #4680

Closed
wants to merge 1 commit into from

Conversation

yiranlau
Copy link

@yiranlau yiranlau commented Jul 28, 2019

What is the purpose of the change

#4470 fix referenceAnnotation config not work when a dubbo service was referenced multi times

@mercyblitz have tried to fix this issue at 2.6.6 but not work. and I found the referencedBeanName was not really changed.

@bigwg
Copy link
Contributor

bigwg commented Jul 28, 2019

This solution will create the same number of spring beans as you use @reference in your project

@yiranlau
Copy link
Author

yiranlau commented Jul 28, 2019

This solution will create the same number of spring beans as you use @reference in your project

yes, you are right. but I think it would be accepted if we want to implement consumer side onconnect or ondisconnect event callback as notied at #4580, which I still cannot figure out how to transport a bean proxy object which have injected bean field to DubboProtocol onconnect event or ondisconnect event.

@bigwg
Copy link
Contributor

bigwg commented Jul 29, 2019

This solution will create the same number of spring beans as you use @reference in your project

yes, you are right. but I think it would be accepted if we want to implement consumer side onconnect or ondisconnect event callback as notied at #4580, which I still cannot figure out how to transport a bean proxy object which have injected bean field to DubboProtocol onconnect event or ondisconnect event.

I can't figure out too, but I think this scenario is not enough gracefully, we may get another solution that gracefully than it

@beiwei30
Copy link
Member

this solution is not correct, close now. Pls. refer @mercyblitz 's comment at the original issue.

@beiwei30 beiwei30 closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants