Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix StringUtils#isBlank #4725

Merged
merged 1 commit into from
Aug 3, 2019
Merged

fix StringUtils#isBlank #4725

merged 1 commit into from
Aug 3, 2019

Conversation

hengyunabc
Copy link
Contributor

isBlank is not the same as isEmpty

@codecov-io
Copy link

Codecov Report

Merging #4725 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4725      +/-   ##
============================================
+ Coverage     63.92%   63.95%   +0.02%     
+ Complexity      451      450       -1     
============================================
  Files           769      769              
  Lines         33160    33165       +5     
  Branches       5226     5228       +2     
============================================
+ Hits          21199    21211      +12     
+ Misses         9543     9531      -12     
- Partials       2418     2423       +5
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/common/utils/StringUtils.java 84.01% <50%> (-0.84%) 0 <0> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.7% <0%> (-1.18%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.58% <0%> (-0.37%) 0% <0%> (ø)
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 80.74% <0%> (+0.74%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (+1.53%) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.68% <0%> (+1.8%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1173b40...00db486. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beiwei30 beiwei30 merged commit a8785e9 into apache:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants