Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo. #4739

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Fix typo. #4739

merged 1 commit into from
Aug 5, 2019

Conversation

wayilau
Copy link
Member

@wayilau wayilau commented Aug 5, 2019

What is the purpose of the change

Fix typo. build used following can, not built.

@codecov-io
Copy link

Codecov Report

Merging #4739 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4739      +/-   ##
============================================
- Coverage     63.98%   63.92%   -0.07%     
+ Complexity      452      451       -1     
============================================
  Files           769      769              
  Lines         33178    33178              
  Branches       5229     5229              
============================================
- Hits          21229    21209      -20     
- Misses         9525     9548      +23     
+ Partials       2424     2421       -3
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 65.85% <0%> (-17.08%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 56.47% <0%> (-2.36%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.58% <0%> (-0.37%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (+4.34%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87703ad...943a835. Read the comment docs.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit 62e194a into apache:master Aug 5, 2019
@wayilau wayilau deleted the fix_typo branch August 5, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants