Dubbo Cloud Native

.travis.yml

@@ -12,7 +12,7 @@ cache:
 install: true
 
 script:
-  - travis_wait 30 ./mvnw clean install -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true
+  - travis_wait 30 ./mvnw --quiet clean install -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true
 
 after_success:
   - bash <(curl -s https://codecov.io/bash)

dubbo-bom/pom.xml

@@ -23,6 +23,7 @@
         <groupId>org.apache.dubbo</groupId>
         <artifactId>dubbo-parent</artifactId>
         <version>${revision}</version>
+        <relativePath>../pom.xml</relativePath>
     </parent>
 
     <artifactId>dubbo-bom</artifactId>

dubbo-bootstrap/pom.xml

@@ -26,14 +26,7 @@
 
         <!-- Test dependencies -->
 
-
-        <dependency>
-            <groupId>org.apache.dubbo</groupId>
-            <artifactId>dubbo-configcenter-zookeeper</artifactId>
-            <version>${project.parent.version}</version>
-            <scope>test</scope>
-        </dependency>
-
+        <!-- Zookeeper dependencies for testing -->
         <dependency>
             <groupId>org.apache.dubbo</groupId>
             <artifactId>dubbo-registry-zookeeper</artifactId>
@@ -48,29 +41,13 @@
             <scope>test</scope>
         </dependency>
 
-        <!-- Zookeeper dependencies for testing -->
         <dependency>
             <groupId>org.apache.dubbo</groupId>
-            <artifactId>dubbo-registry-etcd3</artifactId>
-            <version>${project.parent.version}</version>
-<!--            <scope>test</scope>-->
-        </dependency>
-
-        <dependency>
-            <groupId>org.apache.dubbo</groupId>
-            <artifactId>dubbo-metadata-report-etcd</artifactId>
-            <version>${project.parent.version}</version>
-            <scope>test</scope>
-        </dependency>
-
-        <dependency>
-            <groupId>org.apache.dubbo</groupId>
-            <artifactId>dubbo-configcenter-etcd</artifactId>
+            <artifactId>dubbo-configcenter-zookeeper</artifactId>
             <version>${project.parent.version}</version>
             <scope>test</scope>
         </dependency>
 
-
         <!-- Nacos dependencies for testing -->
         <dependency>
             <groupId>org.apache.dubbo</groupId>
@@ -113,17 +90,6 @@
             <scope>test</scope>
         </dependency>
 
-<!--        <dependency>-->
-<!--            <groupId>com.google.guava</groupId>-->
-<!--            <artifactId>guava</artifactId>-->
-<!--            <version>20.0</version>-->
-<!--        </dependency>-->
-        <dependency>
-            <groupId>org.apache.curator</groupId>
-            <artifactId>curator-test</artifactId>
-            <scope>test</scope>
-        </dependency>
-
     </dependencies>
 
-</project>
+</project>

dubbo-bootstrap/src/main/java/org/apache/dubbo/bootstrap/DubboBootstrap.java

@@ -57,7 +57,6 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -77,7 +76,6 @@
 import static org.apache.dubbo.common.utils.StringUtils.isNotEmpty;
 import static org.apache.dubbo.config.context.ConfigManager.getInstance;
 import static org.apache.dubbo.registry.support.AbstractRegistryFactory.getRegistries;
-import static org.apache.dubbo.remoting.Constants.CLIENT_KEY;
 
 /**
  * The bootstrap class of Dubbo
@@ -114,19 +112,14 @@ public class DubboBootstrap {
 
     private final ConfigManager configManager = getInstance();
 
-    /**
-     * Is provider or not
-     */
-    private boolean isProvider;
-
-    private boolean initialized = false;
+    private volatile boolean initialized = false;
 
-    private boolean started = false;
+    private volatile boolean started = false;
 
     /**
      * Only Provider Register
      */
-    private boolean onlyRegisterProvider = false;
+    private volatile boolean onlyRegisterProvider = false;
 
     private ServiceInstance serviceInstance;
 
@@ -155,6 +148,7 @@ public DubboBootstrap metadataReport(List<MetadataReportConfig> metadataReportCo
         return this;
     }
 
+
     // {@link ApplicationConfig} correlative methods
 
     /**
@@ -193,6 +187,7 @@ public DubboBootstrap application(ApplicationConfig applicationConfig) {
         return this;
     }
 
+
     // {@link RegistryConfig} correlative methods
 
     /**
@@ -240,8 +235,8 @@ public DubboBootstrap registries(Iterable<RegistryConfig> registryConfigs) {
         return this;
     }
 
-    // {@link ProtocolConfig} correlative methods
 
+    // {@link ProtocolConfig} correlative methods
     public DubboBootstrap protocol(Consumer<ProtocolBuilder> consumerBuilder) {
         return protocol(DEFAULT_PROTOCOL_ID, consumerBuilder);
     }
@@ -261,8 +256,8 @@ public DubboBootstrap protocols(List<ProtocolConfig> protocolConfigs) {
         return this;
     }
 
-    // {@link ServiceConfig} correlative methods
 
+    // {@link ServiceConfig} correlative methods
     public <S> DubboBootstrap service(Consumer<ServiceBuilder<S>> consumerBuilder) {
         return service(DEFAULT_SERVICE_ID, consumerBuilder);
     }
@@ -278,8 +273,8 @@ public DubboBootstrap service(ServiceConfig<?> serviceConfig) {
         return this;
     }
 
-    // {@link Reference} correlative methods
 
+    // {@link Reference} correlative methods
     public <S> DubboBootstrap reference(Consumer<ReferenceBuilder<S>> consumerBuilder) {
         return reference(DEFAULT_REFERENCE_ID, consumerBuilder);
     }
@@ -295,8 +290,8 @@ public DubboBootstrap reference(ReferenceConfig<?> referenceConfig) {
         return this;
     }
 
-    // {@link ProviderConfig} correlative methods
 
+    // {@link ProviderConfig} correlative methods
     public DubboBootstrap provider(Consumer<ProviderBuilder> builderConsumer) {
         return provider(DEFAULT_PROVIDER_ID, builderConsumer);
     }
@@ -316,8 +311,8 @@ public DubboBootstrap providers(List<ProviderConfig> providerConfigs) {
         return this;
     }
 
-    // {@link ConsumerConfig} correlative methods
 
+    // {@link ConsumerConfig} correlative methods
     public DubboBootstrap consumer(Consumer<ConsumerBuilder> builderConsumer) {
         return consumer(DEFAULT_CONSUMER_ID, builderConsumer);
     }
@@ -338,6 +333,7 @@ public DubboBootstrap consumers(List<ConsumerConfig> consumerConfigs) {
     }
 
     // {@link ConfigCenterConfig} correlative methods
+
     public DubboBootstrap configCenter(ConfigCenterConfig configCenterConfig) {
         return configCenter(asList(configCenterConfig));
     }
@@ -424,13 +420,8 @@ private void useRegistryAsConfigCenterIfNecessary() {
             String id = "config-center-" + protocol + "-" + registryConfig.getPort();
             ConfigCenterConfig cc = new ConfigCenterConfig();
             cc.setId(id);
-            cc.setParameters(registryConfig.getParameters() == null ?
-                    new HashMap<>() :
-                    new HashMap<>(registryConfig.getParameters()));
-            cc.getParameters().put(CLIENT_KEY,registryConfig.getClient());
-            cc.setProtocol(registryConfig.getProtocol());
+            cc.setProtocol(protocol);
             cc.setAddress(registryConfig.getAddress());
-            cc.setNamespace(registryConfig.getGroup());
             cc.setHighestPriority(false);
             configManager.addConfigCenter(cc);
         });
@@ -463,7 +454,6 @@ public DubboBootstrap start() {
                 /**
                  * export {@link MetadataService}
                  */
-                // TODO, only export to default registry?
                 List<URL> exportedURLs = exportMetadataService(
                         configManager.getApplication().orElseThrow(() -> new IllegalStateException("ApplicationConfig cannot be null")),
                         configManager.getRegistries(),
@@ -541,6 +531,7 @@ public boolean isStarted() {
 
 
     /* serve for builder apis, begin */
+
     private ApplicationBuilder createApplicationBuilder(String name) {
         return new ApplicationBuilder().name(name);
     }
@@ -569,8 +560,8 @@ private ConsumerBuilder createConsumerBuilder(String id) {
         return new ConsumerBuilder().id(id);
     }
 
-    /* serve for builder apis, end */
 
+    /* serve for builder apis, end */
     private void startMetadataReport() {
         ApplicationConfig applicationConfig = configManager.getApplication().orElseThrow(() -> new IllegalStateException("There's no ApplicationConfig specified."));
 
@@ -612,15 +603,14 @@ private DynamicConfiguration prepareEnvironment(ConfigCenterConfig configCenter)
                 return null;
             }
             DynamicConfiguration dynamicConfiguration = getDynamicConfiguration(configCenter.toUrl());
-            String configContent = dynamicConfiguration.getProperties(configCenter.getConfigFile(), configCenter.getGroup());
+            String configContent = dynamicConfiguration.getRule(configCenter.getConfigFile(), configCenter.getGroup());
 
             String appGroup = configManager.getApplication().orElse(new ApplicationConfig()).getName();
             String appConfigContent = null;
             if (isNotEmpty(appGroup)) {
-                appConfigContent = dynamicConfiguration.getProperties
-                        (isNotEmpty(configCenter.getAppConfigFile()) ? configCenter.getAppConfigFile() : configCenter.getConfigFile(),
-                                appGroup
-                        );
+                appConfigContent = dynamicConfiguration.getConfig(isNotEmpty(configCenter.getAppConfigFile()) ?
+                        configCenter.getAppConfigFile() : configCenter.getConfigFile(), appGroup
+                );
             }
             try {
                 Environment.getInstance().setConfigCenterFirst(configCenter.isHighestPriority());
@@ -663,6 +653,10 @@ public void exportServiceConfig(ServiceConfig<?> serviceConfig) {
         serviceConfig.export();
     }
 
+    public boolean isOnlyRegisterProvider() {
+        return onlyRegisterProvider;
+    }
+
     private void registerServiceInstance(List<URL> exportedURLs) {
 
         exportedURLs

dubbo-bootstrap/src/test/java/org/apache/dubbo/bootstrap/DubboServiceConsumerBootstrap.java

@@ -19,7 +19,6 @@
 import org.apache.dubbo.config.ReferenceConfig;
 import org.apache.dubbo.config.context.ConfigManager;
 
-
 /**
  * Dubbo Provider Bootstrap
  *

dubbo-bootstrap/src/test/java/org/apache/dubbo/bootstrap/DubboServiceProviderBootstrap.java

@@ -30,7 +30,6 @@ public static void main(String[] args) {
                 .registry("zookeeper", builder -> builder.address("zookeeper://127.0.0.1:2181?registry-type=service"))
                 // Nacos
                 .registry("nacos", builder -> builder.address("nacos://127.0.0.1:8848?registry-type=service"))
-//                .registry(RegistryBuilder.newBuilder().address("etcd3://127.0.0.1:2379?registry-type=service").build())
                 .protocol(builder -> builder.port(-1).name("dubbo"))
                 .service(builder -> builder.id("test").interfaceClass(EchoService.class).ref(new EchoServiceImpl()))
                 .start()

dubbo-cluster/pom.xml

@@ -20,6 +20,7 @@
         <groupId>org.apache.dubbo</groupId>
         <artifactId>dubbo-parent</artifactId>
         <version>${revision}</version>
+        <relativePath>../pom.xml</relativePath>
     </parent>
     <artifactId>dubbo-cluster</artifactId>
     <packaging>jar</packaging>

dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/condition/config/ListenableRouter.java

@@ -119,7 +119,7 @@ private synchronized void init(String ruleKey) {
         }
         String routerKey = ruleKey + RULE_SUFFIX;
         configuration.addListener(routerKey, this);
-        String rule = configuration.getRule(routerKey, DynamicConfiguration.DEFAULT_GROUP);
+        String rule = configuration.getConfig(routerKey, DynamicConfiguration.DEFAULT_GROUP);
         if (StringUtils.isNotEmpty(rule)) {
             this.process(new ConfigChangeEvent(routerKey, rule));
         }

dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/tag/TagRouter.java

@@ -249,7 +249,7 @@ public <T> void notify(List<Invoker<T>> invokers) {
                 String key = providerApplication + RULE_SUFFIX;
                 configuration.addListener(key, this);
                 application = providerApplication;
-                String rawRule = configuration.getRule(key, DynamicConfiguration.DEFAULT_GROUP);
+                String rawRule = configuration.getConfig(key, DynamicConfiguration.DEFAULT_GROUP);
                 if (StringUtils.isNotEmpty(rawRule)) {
                     this.process(new ConfigChangeEvent(key, rawRule));
                 }

dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java

@@ -32,8 +32,8 @@
 
 import java.util.List;
 
-import static org.apache.dubbo.rpc.cluster.Constants.INVOCATION_NEED_MOCK;
 import static org.apache.dubbo.rpc.Constants.MOCK_KEY;
+import static org.apache.dubbo.rpc.cluster.Constants.INVOCATION_NEED_MOCK;
 
 public class MockClusterInvoker<T> implements Invoker<T> {
 

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/TagRouterTest.java

@@ -16,11 +16,12 @@
  */
 package org.apache.dubbo.rpc.cluster.router;
 
+import org.apache.dubbo.rpc.cluster.router.tag.model.TagRouterRule;
+import org.apache.dubbo.rpc.cluster.router.tag.model.TagRuleParser;
+
 import org.apache.curator.framework.CuratorFramework;
 import org.apache.curator.framework.CuratorFrameworkFactory;
 import org.apache.curator.retry.ExponentialBackoffRetry;
-import org.apache.dubbo.rpc.cluster.router.tag.model.TagRouterRule;
-import org.apache.dubbo.rpc.cluster.router.tag.model.TagRuleParser;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java

@@ -47,10 +47,10 @@
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.atomic.AtomicLong;
 
+import static org.apache.dubbo.common.constants.CommonConstants.MONITOR_KEY;
 import static org.apache.dubbo.rpc.cluster.Constants.CLUSTER_AVAILABLE_CHECK_KEY;
 import static org.apache.dubbo.rpc.cluster.Constants.INVOCATION_NEED_MOCK;
 import static org.apache.dubbo.rpc.cluster.Constants.REFER_KEY;
-import static org.apache.dubbo.common.constants.CommonConstants.MONITOR_KEY;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.mock;
 

dubbo-common/pom.xml

@@ -21,6 +21,7 @@
         <groupId>org.apache.dubbo</groupId>
         <artifactId>dubbo-parent</artifactId>
         <version>${revision}</version>
+        <relativePath>../pom.xml</relativePath>
     </parent>
     <artifactId>dubbo-common</artifactId>
     <packaging>jar</packaging>

dubbo-common/src/main/java/org/apache/dubbo/common/config/Configuration.java

@@ -127,6 +127,4 @@ default <T> T convert(Class<T> cls, String key, T defaultValue) {
 
         return cls.cast(obj);
     }
-
-
 }