Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance consul registry to support matching url between consumer and provider #4818

Merged
merged 1 commit into from
Jan 17, 2020
Merged

enhance consul registry to support matching url between consumer and provider #4818

merged 1 commit into from
Jan 17, 2020

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

enhance consul registry to support matching url between consumer and provider

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4818 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4818      +/-   ##
============================================
+ Coverage     63.83%   63.92%   +0.09%     
- Complexity      450      452       +2     
============================================
  Files           769      769              
  Lines         33137    33173      +36     
  Branches       5203     5229      +26     
============================================
+ Hits          21153    21207      +54     
+ Misses         9557     9542      -15     
+ Partials       2427     2424       -3
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.11% <100%> (+0.23%) 30 <1> (+1) ⬆️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 70.73% <0%> (-12.2%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0%> (-2%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
.../main/java/org/apache/dubbo/qos/textui/TTable.java 83.79% <0%> (-0.87%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.41% <0%> (-0.69%) 0% <0%> (ø)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (-0.26%) 31% <0%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e76eb0...9cbed6a. Read the comment docs.

@beiwei30 beiwei30 merged commit 08e00a9 into apache:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants