Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4765] fix demo dependencies #4832

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Conversation

mzorro
Copy link
Contributor

@mzorro mzorro commented Aug 15, 2019

fix issue #4765

@mzorro mzorro changed the title fix demo run fix issue #4765 Aug 15, 2019
@mzorro mzorro changed the title fix issue #4765 [Dubbo-4765] fix demo dependencies Aug 15, 2019
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #4832 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4832      +/-   ##
============================================
+ Coverage     63.31%   63.86%   +0.54%     
+ Complexity      451      449       -2     
============================================
  Files           790      769      -21     
  Lines         35021    33177    -1844     
  Branches       5472     5229     -243     
============================================
- Hits          22175    21189     -986     
+ Misses        10316     9558     -758     
+ Partials       2530     2430     -100
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 70.73% <0%> (-12.2%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 53.84% <0%> (-7.7%) 0% <0%> (ø)
...bbo/registry/support/ProviderConsumerRegTable.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 54.11% <0%> (-3.53%) 19% <0%> (-1%)
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 85% <0%> (-3.34%) 0% <0%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042327c...973eaa9. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the pull request.

@ralf0131 ralf0131 merged commit 171ed25 into apache:master Aug 18, 2019
@mzorro mzorro deleted the fix_demo_api branch August 18, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants