Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code with Lambda #4834

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Simplify code with Lambda #4834

merged 1 commit into from
Aug 16, 2019

Conversation

freekry
Copy link
Contributor

@freekry freekry commented Aug 15, 2019

Simplify code with Lambda

Simplify code with Lambda
@codecov-io
Copy link

Codecov Report

Merging #4834 into master will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #4834     +/-   ##
===========================================
+ Coverage     63.31%   63.91%   +0.6%     
+ Complexity      451      450      -1     
===========================================
  Files           790      769     -21     
  Lines         35021    33174   -1847     
  Branches       5472     5231    -241     
===========================================
- Hits          22172    21203    -969     
+ Misses        10317     9548    -769     
+ Partials       2532     2423    -109
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 65.85% <0%> (-17.08%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 68.21% <0%> (-3.11%) 0% <0%> (ø)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 56.47% <0%> (-2.36%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/common/json/ParseException.java
...o/rpc/protocol/thrift/DubboClassNameGenerator.java
.../java/org/apache/dubbo/common/json/JSONObject.java
.../java/org/apache/dubbo/common/json/JSONWriter.java
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042327c...80c0446. Read the comment docs.

Copy link
Contributor

@lixiaojiee lixiaojiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lixiaojiee lixiaojiee merged commit 8be896e into apache:master Aug 16, 2019
@freekry freekry deleted the v20190815 branch September 1, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants