-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dubbo zookeeper registry too slow #4880
dubbo zookeeper registry too slow #4880
Conversation
...eeper/src/main/java/org/apache/dubbo/remoting/zookeeper/support/AbstractZookeeperClient.java
Show resolved
Hide resolved
I find a branch missing delete the persist node
@tswstarplanet You are right, I find the metaDataReport delete the persist node |
I find a branch missing delete the persist node
Codecov Report
@@ Coverage Diff @@
## master #4880 +/- ##
============================================
- Coverage 63.97% 63.93% -0.04%
- Complexity 452 453 +1
============================================
Files 769 769
Lines 33157 33168 +11
Branches 5228 5232 +4
============================================
- Hits 21211 21206 -5
- Misses 9525 9545 +20
+ Partials 2421 2417 -4
Continue to review full report at Codecov.
|
...eeper/src/main/java/org/apache/dubbo/remoting/zookeeper/support/AbstractZookeeperClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change looks good except for explicitly using guava, pls. change it. @qixiaobo
change to dubbo concurrenthashset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref to #4828
I just add concurrentHashSet to avoid checking persistent node exist