-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplifed and beautify code #4921
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4921 +/- ##
============================================
+ Coverage 63.96% 63.98% +0.02%
Complexity 451 451
============================================
Files 769 769
Lines 33160 33160
Branches 5230 5230
============================================
+ Hits 21210 21217 +7
+ Misses 9525 9521 -4
+ Partials 2425 2422 -3
Continue to review full report at Codecov.
|
@leechor would you mind to take look into CI? there are unit tests failing. |
misunderstand a method's function, and the unit test of this method not contains this case, have fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
simplifed and beautify code.not change behaviour.
pass.