Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifed and beautify code #4921

Merged
merged 17 commits into from
Sep 3, 2019
Merged

simplifed and beautify code #4921

merged 17 commits into from
Sep 3, 2019

Conversation

leechor
Copy link
Contributor

@leechor leechor commented Aug 23, 2019

What is the purpose of the change

simplifed and beautify code.not change behaviour.
pass.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #4921 into master will increase coverage by 0.02%.
The diff coverage is 50.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4921      +/-   ##
============================================
+ Coverage     63.96%   63.98%   +0.02%     
  Complexity      451      451              
============================================
  Files           769      769              
  Lines         33160    33160              
  Branches       5230     5230              
============================================
+ Hits          21210    21217       +7     
+ Misses         9525     9521       -4     
+ Partials       2425     2422       -3
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/utils/CompatibleTypeUtils.java 66.34% <43.24%> (ø) 0 <0> (ø) ⬇️
...va/org/apache/dubbo/common/utils/ReflectUtils.java 71.07% <55.35%> (ø) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.54%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (-0.94%) 16% <0%> (-1%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.5% <0%> (+0.62%) 29% <0%> (ø) ⬇️
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 88.33% <0%> (+3.33%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (+4.34%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 62.35% <0%> (+4.7%) 21% <0%> (+1%) ⬆️
...bbo/registry/support/ProviderConsumerRegTable.java 85.36% <0%> (+4.87%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c4677...37e3705. Read the comment docs.

@beiwei30
Copy link
Member

@leechor would you mind to take look into CI? there are unit tests failing.

@leechor
Copy link
Contributor Author

leechor commented Aug 23, 2019

@leechor would you mind to take look into CI? there are unit tests failing.

misunderstand a method's function, and the unit test of this method not contains this case, have fix it.

@beiwei30 beiwei30 added this to the 2.7.4 milestone Sep 3, 2019
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beiwei30 beiwei30 merged commit 3702887 into apache:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants