-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Apollo config center mock test #4948
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## master #4948 +/- ##
============================================
- Coverage 64.01% 63.91% -0.11%
+ Complexity 453 450 -3
============================================
Files 769 769
Lines 33160 33163 +3
Branches 5230 5229 -1
============================================
- Hits 21229 21197 -32
- Misses 9513 9540 +27
- Partials 2418 2426 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slievrly pls. check my comments.
Correct, in my opinion, they should be removed too since the end user should not rely on the libraries used for unit test. It would be nice if you can file a new issue to track this particular issue, so we could discuss further whether we should keep test libraries in this bom. |
@beiwei30 In fact, I want to keep apollo-client and apollo-mockserver in the same version. The apollo_client_version property is defined in dubbo-dependencies-bom. If apollo-mockserver is placed in the apollo module, this property will not be accessible. |
Signed-off-by: slievrly <slievrly@163.com>
@beiwei30 already move apollo-mockserver dependency to apollo module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: slievrly slievrly@163.com
What is the purpose of the change
add Apollo config center mock test
Brief changelog
[Test] add Apollo config center mock test
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.