Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Apollo config center mock test #4948

Merged
merged 4 commits into from
Sep 5, 2019
Merged

add Apollo config center mock test #4948

merged 4 commits into from
Sep 5, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 26, 2019

Signed-off-by: slievrly slievrly@163.com

What is the purpose of the change

add Apollo config center mock test

Brief changelog

[Test] add Apollo config center mock test

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #4948 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4948      +/-   ##
============================================
- Coverage     64.01%   63.91%   -0.11%     
+ Complexity      453      450       -3     
============================================
  Files           769      769              
  Lines         33160    33163       +3     
  Branches       5230     5229       -1     
============================================
- Hits          21229    21197      -32     
- Misses         9513     9540      +27     
- Partials       2418     2426       +8
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 70.73% <0%> (-12.2%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-3.07%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-2.81%) 16% <0%> (-1%)
...ache/dubbo/rpc/protocol/rest/RpcContextFilter.java 61.11% <0%> (-2.53%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 65.09% <0%> (-1.89%) 0% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c4677...256ecf1. Read the comment docs.

@htynkn htynkn self-requested a review August 31, 2019 00:47
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slievrly pls. check my comments.

@slievrly
Copy link
Member Author

slievrly commented Sep 3, 2019

@slievrly pls. check my comments.

@beiwei30 I found some dependencies which scope defined as test in dubbo-dependencies-bom,do I also need to move them?

image

@beiwei30
Copy link
Member

beiwei30 commented Sep 3, 2019

@slievrly pls. check my comments.

@beiwei30 I found some dependencies which scope defined as test in dubbo-dependencies-bom,do I also need to move them?

Correct, in my opinion, they should be removed too since the end user should not rely on the libraries used for unit test.

It would be nice if you can file a new issue to track this particular issue, so we could discuss further whether we should keep test libraries in this bom.

@slievrly
Copy link
Member Author

slievrly commented Sep 3, 2019

@beiwei30 In fact, I want to keep apollo-client and apollo-mockserver in the same version. The apollo_client_version property is defined in dubbo-dependencies-bom. If apollo-mockserver is placed in the apollo module, this property will not be accessible.

Signed-off-by: slievrly <slievrly@163.com>
@slievrly
Copy link
Member Author

slievrly commented Sep 3, 2019

@beiwei30 already move apollo-mockserver dependency to apollo module.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beiwei30 beiwei30 merged commit 597cda8 into apache:master Sep 5, 2019
@beiwei30 beiwei30 added this to the 2.7.4 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants