Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish #4674 & #4470 #5033

Merged
merged 5 commits into from
Sep 9, 2019
Merged

Polish #4674 & #4470 #5033

merged 5 commits into from
Sep 9, 2019

Conversation

mercyblitz
Copy link
Contributor

To resovle issues: #4674 & #4470

@codecov-io
Copy link

Codecov Report

Merging #5033 into master will decrease coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5033      +/-   ##
============================================
- Coverage     63.97%   63.96%   -0.02%     
  Complexity      452      452              
============================================
  Files           769      769              
  Lines         33182    33181       -1     
  Branches       5232     5230       -2     
============================================
- Hits          21229    21224       -5     
- Misses         9532     9534       +2     
- Partials       2421     2423       +2
Impacted Files Coverage Δ Complexity Δ
...notation/ReferenceAnnotationBeanPostProcessor.java 87.61% <93.33%> (-0.12%) 0 <0> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 63.63% <0%> (-1.14%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (-0.94%) 16% <0%> (-1%)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 58.82% <0%> (+2.35%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 60.22% <0%> (+4.54%) 21% <0%> (+1%) ⬆️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 70.73% <0%> (+4.87%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c536eec...163e31a. Read the comment docs.

@mercyblitz mercyblitz merged commit 62a32aa into apache:master Sep 9, 2019
@cvictory cvictory added this to the 2.7.4 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants