Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos #5044

Merged
merged 1 commit into from
Sep 11, 2019
Merged

fix some typos #5044

merged 1 commit into from
Sep 11, 2019

Conversation

Hearen
Copy link
Contributor

@Hearen Hearen commented Sep 10, 2019

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #5044 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5044      +/-   ##
============================================
- Coverage     63.94%   63.93%   -0.02%     
- Complexity      451      453       +2     
============================================
  Files           769      769              
  Lines         33194    33194              
  Branches       5236     5236              
============================================
- Hits          21226    21222       -4     
- Misses         9543     9548       +5     
+ Partials       2425     2424       -1
Impacted Files Coverage Δ Complexity Δ
...pc/cluster/loadbalance/LeastActiveLoadBalance.java 88.88% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-3.07%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-2.18%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.36%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.41% <0%> (-0.35%) 0% <0%> (ø)
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 67.37% <0%> (+0.7%) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 90.65% <0%> (+0.93%) 17% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.77% <0%> (+1.13%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9275b9d...a9aec64. Read the comment docs.

@htynkn
Copy link
Member

htynkn commented Sep 11, 2019

Thanks for your contribution.

@htynkn htynkn merged commit 39edc80 into apache:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants