Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not use IdentityHashMap, otherwise cannot use method object to get #5675

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

switch from IdentityHashMap to HashMap

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from qinliujie January 16, 2020 12:38
@beiwei30 beiwei30 added this to the 2.7.6 milestone Jan 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #5675 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5675      +/-   ##
============================================
- Coverage     61.13%   61.13%   -0.01%     
+ Complexity      422      421       -1     
============================================
  Files           923      923              
  Lines         37568    37568              
  Branches       5441     5441              
============================================
- Hits          22969    22967       -2     
- Misses        12103    12105       +2     
  Partials       2496     2496
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/dubbo/rpc/model/ConsumerModel.java 58.13% <100%> (ø) 0 <0> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 77.15% <0%> (-3%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) 8% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0%> (-1%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (+0.68%) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0%> (+1.9%) 16% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0%> (+3.5%) 9% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f58d4...452b6de. Read the comment docs.

@qinliujie
Copy link
Contributor

LGTM

@qinliujie qinliujie merged commit a9a69ea into apache:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants