[DUBBO-2.7.8]Fix DynamicConfiguration namespace property read bug when use custom namespace #6717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue
#6606
What is the purpose of the change
Fix ConfigCenter namespace read bug in apollo, etcd and so on.
修复apollo、etcd等配置中心读取namespace错误的bug。
Brief changelog
use org.apache.dubbo.common.constants.CommonConstants#CONFIG_NAMESPACE_KEY instead of org.apache.dubbo.common.config.configcenter.Constants#CONFIG_NAMESPACE_KEY.
在apollo、etcd等配置中心的实现中,使用org.apache.dubbo.common.constants.CommonConstants#CONFIG_NAMESPACE_KEY 来替换org.apache.dubbo.common.config.configcenter.Constants#CONFIG_NAMESPACE_KEY,确保自配置的配置中心namespace可以正确读取。
Verifying this change
All unit tests have passed.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.