Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-6887] Fix the consumer accidentally using FixedThreadPool, resulting in threads starting with Dubbo-thread-xxx prefix #6888

Closed
wants to merge 1 commit into from

Conversation

tongxiao0622
Copy link

What is the purpose of the change

#6887

Brief changelog

There are many threads named with Dubbo-thread-xxx on the consumer side,these threads will not be recycled.
(中文:消费方出现了很多以Dubbo-thread-xxx命名的线程,这些线程不会被回收)

Verifying this change

消费方感知到提供方下线或者禁用

AllChannelHandler#disconnected -> getExecutorService() -> getSharedExecutorService()
-> DefaultExecutorRepository#getExecutor -> 此时消费方关联线程池已关闭(executor.isShutdown() || executor.isTerminated()) -> createExecutor(url)

上面的URL并不存在threadname、threadpool参数,导致消费方创建了FixedThreadPool线程池

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@tongxiao0622 tongxiao0622 changed the title fix 6887 [Dubbo-6887] Fix the consumer accidentally using FixedThreadPool, resulting in threads starting with Dubbo-thread-xxx prefix Nov 8, 2020
@AlbumenJ
Copy link
Member

@tongxiao0622 Hi, thanks for your contribution.

Please merge the latest master to resolve confilcts.

@AlbumenJ AlbumenJ added the status/waiting-for-feedback Need reporters to triage label Apr 12, 2021
@AlbumenJ
Copy link
Member

Close for long time no response.

Please feel free to reopen if you have any question.

If you think these changes still useful in the latest master branch, please submit a new pull request.

@AlbumenJ AlbumenJ closed this May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants