[Dubbo-6887] Fix the consumer accidentally using FixedThreadPool, resulting in threads starting with Dubbo-thread-xxx prefix #6888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#6887
Brief changelog
There are many threads named with Dubbo-thread-xxx on the consumer side,these threads will not be recycled.
(中文:消费方出现了很多以Dubbo-thread-xxx命名的线程,这些线程不会被回收)
Verifying this change
消费方感知到提供方下线或者禁用
AllChannelHandler#disconnected -> getExecutorService() -> getSharedExecutorService()
-> DefaultExecutorRepository#getExecutor -> 此时消费方关联线程池已关闭(executor.isShutdown() || executor.isTerminated()) -> createExecutor(url)
上面的URL并不存在threadname、threadpool参数,导致消费方创建了FixedThreadPool线程池
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.