Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-#6946] fix:fix bug @Wrapper without annotations @Retention cause extension s… #6947

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

soft641400589
Copy link

@soft641400589 soft641400589 commented Nov 26, 2020

…et matches and mismatches invalid

What is the purpose of the change

fix bug @wrapper without annotations @retention

Brief changelog

fix:fix bug @wrapper without annotations @retention cause extension set matches and mismatches invalid

github issues address #6946

@soft641400589 soft641400589 changed the title fix:fix bug @Wrapper without annotations @Retention cause extension s… [DUBBO-#6946] fix:fix bug @Wrapper without annotations @Retention cause extension s… Nov 27, 2020
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #6947 (7320228) into master (3fc2d10) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6947      +/-   ##
============================================
- Coverage     59.44%   59.17%   -0.27%     
+ Complexity      511      507       -4     
============================================
  Files          1028     1028              
  Lines         41519    41519              
  Branches       6037     6037              
============================================
- Hits          24679    24568     -111     
- Misses        14104    14182      +78     
- Partials       2736     2769      +33     
Impacted Files Coverage Δ Complexity Δ
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.35% <0.00%> (-13.68%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-10.17%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 90.00% <0.00%> (-7.50%) 0.00% <0.00%> (ø%)
...apache/dubbo/common/config/ConfigurationUtils.java 58.62% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...7320228. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit d0b894d into apache:master Feb 25, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants